-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate RecipesBase
and RecipesPipeline
into Plots
#4419
Conversation
Add compat for RecipesBase
Co-Authored-By: Anshul Singhvi <asinghvi17@simons-rock.edu>
Credit: Fredrik Ekre
Add integration tests for Plots.jl
Literate + enable deploy
Docs deployment
allow type recipes for `Number`s in arrays and surfaces
The merge of $ sudo apt install git-filter-repo
# clone all repos (vanilla)
git clone https://github.com/JuliaPlots/RecipesPipeline.jl
git clone https://github.com/JuliaPlots/RecipesBase.jl
git clone https://github.com/JuliaPlots/Plots.jl
RecipesPipeline=$PWD/RecipesPipeline.jl
RecipesBase=$PWD/RecipesBase.jl
Plots=$PWD/Plots.jl
# create a dedicated branch for this PR
(cd $Plots; git checkout -b rb_rp_hist)
# process `RecipesBase`
(
cd $RecipesBase
git filter-repo --to-subdirectory-filter RecipesBase
)
(
cd $Plots
git remote add RecipesBase $RecipesBase
git fetch $RecipesBase master
git merge --allow-unrelated-histories FETCH_HEAD
git remote remove RecipesBase
)
# process `RecipesPipeline` (same procedure as previous)
(
cd $RecipesPipeline
git filter-repo --to-subdirectory-filter RecipesPipeline
)
(
cd $Plots
git remote add RecipesPipeline $RecipesPipeline
git fetch $RecipesPipeline master
git merge --allow-unrelated-histories FETCH_HEAD
git remote remove RecipesPipeline
) The following sanity check passes (inspired from JuliaRegistries/General#35965 (comment)): using TOML
cd("Plots.jl")
for pkg ∈ ("RecipesBase", "RecipesPipeline", "Plots")
versions = TOML.parsefile(joinpath(first(DEPOT_PATH), "registries", "General", pkg[1:1], pkg, "Versions.toml"))
found = all(sort(collect(keys(versions)))) do version
tree_sha = versions[version]["git-tree-sha1"]
try
readchomp(`git rev-parse -q --verify "$(tree_sha)^{tree}"`)
return true
catch
return false
end
end
println(pkg, ": ", found ? "all versions found!" : "ney")
end @DilumAluthge, can I request your expertise on this procedure, regarding the julia @BeastyBlacksmith, I'm requesting your review again. |
honestly, I don't know how I could test that |
Thanks, normally, the sanity check above should cover that (i.e. if the I have also checked installation against a single depot with this julia> first(DEPOT_PATH)
# points to a modified local registry
(@v1.8) pkg> activate --temp
(jl_zodEAE) pkg> add Plots@1.30.0 # test adding an old version
[...] |
Codecov ReportBase: 80.63% // Head: 80.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4419 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 30 30
Lines 7469 7469
=======================================
Hits 6023 6023
Misses 1446 1446 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
RecipesBase
and RecipesPipeline
into Plots
Fix #4359.
Setup common
CI
:RecipesBase
>RecipesPipeline
>Plots
.RecipesPipeline
will benefit from this since we won't have to testPlots
examples inRecipesPipeline
.The
CI
overhead is negligible:~10s
for testingRecipesBase
and~50s
for testingRecipesPipeline
.PR
in https://github.com/JuliaRegistries/General, with the following content:https://github.com/JuliaRegistries/General/blob/master/R/RecipesBase/Package.toml
https://github.com/JuliaRegistries/General/blob/master/R/RecipesPipeline/Package.toml
RecipesBase.jl
andRecipesPipeline.jl
reposPlotDocs.jl
(see addRecipesBase
andRecipesPipeline
docs PlotDocs.jl#305)Plots.jl
, with a corresponding tag for triage