Apply recipes to keyword arguments #4453
Open
+52
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/axes.jl
Outdated
| @@ -81,6 +81,7 @@ end | |||
| function attr!(axis::Axis, args...; kw...) | |||
| # first process args | |||
| plotattributes = axis.plotattributes | |||
| dummy_attributes = Dict{Symbol, Any}(:plot_object=>first(axis.sps).plt) | |||
There was a problem hiding this comment.
What are those needed for?
There was a problem hiding this comment.
Good question. RecipesPipeline._apply_type_recipe has
Plots.jl/RecipesPipeline/src/type_recipe.jl
Lines 18 to 25 in 399ee6a
where it asks the first argument for
:plot_object, which it then uses for pre- and postprocessing. Perhaps the function should instead be extended to accept an Axis object instead or something, this just seemed like the minimum intrusion operation to me.
Codecov ReportBase: 80.60% // Head: 79.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4453 +/- ##
==========================================
- Coverage 80.60% 79.88% -0.73%
==========================================
Files 30 40 +10
Lines 7466 8196 +730
==========================================
+ Hits 6018 6547 +529
- Misses 1448 1649 +201
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gustaphe
force-pushed
the
kwarg-recipes
branch
from
7ba2d7f to
2c90439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some keyword arguments which it makes sense to interpret as "on a data axis" - meaning that it would be useful to query the recipe pipeline for how to interpret user provided types.
Some such arguments that I have identified are
marker_zand friendsmarker_size(this one is questionable)So far, a number of these have been hardcoded for
UnitfulandDates, which are two of the most obvious use cases, but if a user wanted to be able to set limits in their own data type they would have to either override unexported Plots functions or handle the conversion toTuple{Float, Float}themselves. With this PR, a type recipe is enough.