Refactor marker and line attributes #4505
Open
+744
−613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit da25f97.
BeastyBlacksmith
force-pushed
the
bbs/marknline
branch
from
dab5780 to
0efda09
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/arg_desc.jl
Outdated
Comment on lines
13
to
15
| :fillrange => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.", | ||
| :fillcolor => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.", | ||
| :fillalpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.", |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :fillrange => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.", | |
| :fillcolor => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.", | |
| :fillalpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.", | |
| :fillrange => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.", | |
| :fillcolor => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.", | |
| :fillalpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.", |
src/arg_desc.jl
Outdated
| :fillrange => "Number or AbstractVector. Fills area between fillrange and y for line-types, sets the base for bar/stick types, and similar for other types.", | ||
| :fillcolor => "Color Type. Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`.", | ||
| :fillalpha => "Number in [0,1]. The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor.", | ||
| :markershape => "Symbol, Shape, or AbstractVector. Choose from $(_allMarkers).", | ||
| :marker_shape => "Symbol, Shape, or AbstractVector. Choose from $(_allMarkers).", | ||
| :fillstyle => "Symbol. Style of the fill area. `nothing` (the default) means solid fill. Choose from :/, :\\, :|, :-, :+, :x", |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :fillstyle => "Symbol. Style of the fill area. `nothing` (the default) means solid fill. Choose from :/, :\\, :|, :-, :+, :x", | |
| :fillstyle => "Symbol. Style of the fill area. `nothing` (the default) means solid fill. Choose from :/, :\\, :|, :-, :+, :x", |
src/args.jl
Outdated
|
|
||
| const _keyAliases = Dict{Symbol,Symbol}() | ||
| const _generalAliases = ("background" => "bg", "foreground" => "fg", "pointsize" => "size", "yfill" => "fill", "alpha" => "a", "alpha" => "opacity", "alpha" => "α") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const _generalAliases = ("background" => "bg", "foreground" => "fg", "pointsize" => "size", "yfill" => "fill", "alpha" => "a", "alpha" => "opacity", "alpha" => "α") | |
| const _generalAliases = ( | |
| "background" => "bg", | |
| "foreground" => "fg", | |
| "pointsize" => "size", | |
| "yfill" => "fill", | |
| "alpha" => "a", | |
| "alpha" => "opacity", | |
| "alpha" => "α", | |
| ) |
src/args.jl
Outdated
Comment on lines
2080
to
2086
| plotattributes[:marker_stroke_color] = if plotattributes[:marker_stroke_color] === :match | ||
| plot_color(sp[:foreground_color_subplot]) | ||
| elseif plotattributes[:markerstrokecolor] === :auto | ||
| get_series_color(plotattributes[:markercolor], sp, plotIndex, stype) | ||
| elseif plotattributes[:marker_stroke_color] === :auto | ||
| get_series_color(plotattributes[:marker_color], sp, plotIndex, stype) | ||
| else | ||
| get_series_color(plotattributes[:markerstrokecolor], sp, plotIndex, stype) | ||
| get_series_color(plotattributes[:marker_stroke_color], sp, plotIndex, stype) | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| plotattributes[:marker_stroke_color] = if plotattributes[:marker_stroke_color] === :match | |
| plot_color(sp[:foreground_color_subplot]) | |
| elseif plotattributes[:markerstrokecolor] === :auto | |
| get_series_color(plotattributes[:markercolor], sp, plotIndex, stype) | |
| elseif plotattributes[:marker_stroke_color] === :auto | |
| get_series_color(plotattributes[:marker_color], sp, plotIndex, stype) | |
| else | |
| get_series_color(plotattributes[:markerstrokecolor], sp, plotIndex, stype) | |
| get_series_color(plotattributes[:marker_stroke_color], sp, plotIndex, stype) | |
| end | |
| plotattributes[:marker_stroke_color] = | |
| if plotattributes[:marker_stroke_color] === :match | |
| plot_color(sp[:foreground_color_subplot]) | |
| elseif plotattributes[:marker_stroke_color] === :auto | |
| get_series_color(plotattributes[:marker_color], sp, plotIndex, stype) | |
| else | |
| get_series_color(plotattributes[:marker_stroke_color], sp, plotIndex, stype) | |
| end |
src/args.jl
Outdated
Comment on lines
2186
to
2191
| pl_aliases = Plots.makeplural.(aliases) | ||
| push!( | ||
| insert_block.args, | ||
| :(Plots.add_aliases($(QuoteNode(exp_key)), $(aliases)..., $(pl_aliases)..., $(Iterators.flatten(Plots.make_non_underscore.(aliases)))..., $(Iterators.flatten(Plots.make_non_underscore.(pl_aliases)))..., | ||
| )) | ||
| ) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| pl_aliases = Plots.makeplural.(aliases) | |
| push!( | |
| insert_block.args, | |
| :(Plots.add_aliases($(QuoteNode(exp_key)), $(aliases)..., $(pl_aliases)..., $(Iterators.flatten(Plots.make_non_underscore.(aliases)))..., $(Iterators.flatten(Plots.make_non_underscore.(pl_aliases)))..., | |
| )) | |
| ) | |
| pl_aliases = Plots.makeplural.(aliases) | |
| push!( | |
| insert_block.args, | |
| :(Plots.add_aliases( | |
| $(QuoteNode(exp_key)), | |
| $(aliases)..., | |
| $(pl_aliases)..., | |
| $(Iterators.flatten(Plots.make_non_underscore.(aliases)))..., | |
| $(Iterators.flatten(Plots.make_non_underscore.(pl_aliases)))..., | |
| )), | |
| ) |
src/components.jl
Outdated
Comment on lines
836
to
838
| :legend_position => (:legend, :leg, :key), | ||
| :legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend), | ||
| :legend_foreground_color => (:foreground_legend, :foreground_colour_legend, :foreground_colour_legend) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :legend_position => (:legend, :leg, :key), | |
| :legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend), | |
| :legend_foreground_color => (:foreground_legend, :foreground_colour_legend, :foreground_colour_legend) | |
| :legend_position => (:legend, :leg, :key), | |
| :legend_background_color => | |
| (:background_legend, :background_colour_legend, :background_color_legend), | |
| :legend_foreground_color => | |
| (:foreground_legend, :foreground_colour_legend, :foreground_colour_legend), |
src/components.jl
Outdated
| :line_alpha => (:lalpha,), | ||
| :line_width => (:w, :width, :lw), | ||
| :line_style => (:s, :style, :ls), | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/components.jl
Outdated
| :marker_stroke_alpha => (:msalpha,), | ||
| :marker_stroke_width => (:msw, :mswidth), | ||
| ) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
test/test_args.jl
Outdated
| @@ -50,8 +50,18 @@ end | |||
| :legend_font_color, | |||
| :legend_title_font_family, | |||
| :legend_title_font_color, | |||
| ) :aliases = Dict( | |||
| :legend_position => (:legend, :leg, :key), | |||
| :legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend), | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend), | |
| :legend_background_color => | |
| (:background_legend, :background_colour_legend, :background_color_legend), |
test/test_recipes.jl
Outdated
Comment on lines
89
to
91
| @test p[1][1][:line_style] == :solid | ||
| @test p[1][2][:line_style] == :dash | ||
| @test p[1][3][:line_style] == :dot |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test p[1][1][:line_style] == :solid | |
| @test p[1][2][:line_style] == :dash | |
| @test p[1][3][:line_style] == :dot | |
| @test p[1][1][:line_style] == :solid | |
| @test p[1][2][:line_style] == :dash | |
| @test p[1][3][:line_style] == :dot |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
src/args.jl
Outdated
| @@ -2248,7 +2225,10 @@ function _splitdef!(blk, key_dict) | |||
| continue | |||
| end | |||
| defexpr = ei.args[2] # defexpr | |||
| key_dict[var] = defexpr | |||
| # filter e.g. marker::Marker = Marker(...) | |||
| if !(defexpr isa Expr && defexpr.head == :call && defexpr.args[1] == ei.args[1].args[2]) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if !(defexpr isa Expr && defexpr.head == :call && defexpr.args[1] == ei.args[1].args[2]) | |
| if !( | |
| defexpr isa Expr && | |
| defexpr.head == :call && | |
| defexpr.args[1] == ei.args[1].args[2] | |
| ) |
src/components.jl
Outdated
Comment on lines
836
to
838
| :legend_position => (:legend, :leg, :key), | ||
| :legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend), | ||
| :legend_foreground_color => (:foreground_legend, :foreground_color_legend, :foreground_colour_legend) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :legend_position => (:legend, :leg, :key), | |
| :legend_background_color => (:background_legend, :background_colour_legend, :background_color_legend), | |
| :legend_foreground_color => (:foreground_legend, :foreground_color_legend, :foreground_colour_legend) | |
| :legend_position => (:legend, :leg, :key), | |
| :legend_background_color => | |
| (:background_legend, :background_colour_legend, :background_color_legend), | |
| :legend_foreground_color => | |
| (:foreground_legend, :foreground_color_legend, :foreground_colour_legend), |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
src/consts.jl
Outdated
| @@ -69,6 +69,8 @@ const _all_plot_args = _plot_args | |||
| const _all_args = | |||
| union(_lettered_all_axis_args, _all_subplot_args, _all_series_args, _all_plot_args) | |||
|
|
|||
| const _all_segmenting_attributes = Set(_segmenting_vector_attributes ∪ _segmenting_array_attributes ∪ reduce(vcat, aliases.(_segmenting_array_attributes)) ∪ reduce(vcat, aliases.(_segmenting_vector_attributes))) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const _all_segmenting_attributes = Set(_segmenting_vector_attributes ∪ _segmenting_array_attributes ∪ reduce(vcat, aliases.(_segmenting_array_attributes)) ∪ reduce(vcat, aliases.(_segmenting_vector_attributes))) | |
| const _all_segmenting_attributes = Set( | |
| _segmenting_vector_attributes ∪ _segmenting_array_attributes ∪ | |
| reduce(vcat, aliases.(_segmenting_array_attributes)) ∪ | |
| reduce(vcat, aliases.(_segmenting_vector_attributes)), | |
| ) |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Comment on lines
+64
to
+68
| RB.@recipe function plot( | ||
| t::T1, | ||
| n::N = 1; | ||
| customcolor = :green, | ||
| ) where {N<:Integer} |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| RB.@recipe function plot( | |
| t::T1, | |
| n::N = 1; | |
| customcolor = :green, | |
| ) where {N<:Integer} | |
| RB.@recipe function plot(t::T1, n::N = 1; customcolor = :green) where {N<:Integer} |
RecipesPipeline/src/utils.jl
Outdated
Comment on lines
16
to
17
| function DefaultsDict{P}(plot_type::Type{P}, explicit::KW, defaults::KW) where P | ||
| e = KW( key_alias(plot_type, k) => v === :seriestype ? type_alias(plot_type, v) : v for (k, v) in explicit) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function DefaultsDict{P}(plot_type::Type{P}, explicit::KW, defaults::KW) where P | |
| e = KW( key_alias(plot_type, k) => v === :seriestype ? type_alias(plot_type, v) : v for (k, v) in explicit) | |
| function DefaultsDict{P}(plot_type::Type{P}, explicit::KW, defaults::KW) where {P} | |
| e = KW( | |
| key_alias(plot_type, k) => v === :seriestype ? type_alias(plot_type, v) : v | |
| for (k, v) in explicit | |
| ) |
RecipesPipeline/src/utils.jl
Outdated
| DefaultsDict(pt, e, d) = DefaultsDict{pt}(pt, e, d) | ||
| function Base.merge(d1::DefaultsDict, d2::DefaultsDict) | ||
| @assert d1.plot_type === d2.plot_type | ||
| DefaultsDict(d1.plot_type, merge(d1.explicit, d2.explicit), merge(d1.defaults, d2.defaults)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| DefaultsDict(d1.plot_type, merge(d1.explicit, d2.explicit), merge(d1.defaults, d2.defaults)) | |
| DefaultsDict( | |
| d1.plot_type, | |
| merge(d1.explicit, d2.explicit), | |
| merge(d1.defaults, d2.defaults), | |
| ) |
RecipesPipeline/test/runtests.jl
Outdated
| @@ -7,7 +7,7 @@ import RecipesPipeline: _prepare_series_data | |||
| import RecipesBase | |||
|
|
|||
| @testset "DefaultsDict" begin | |||
| dd = DefaultsDict(Dict(:foo => 1, :bar => missing), Dict(:foo => nothing, :baz => 'x')) | |||
| dd = DefaultsDict(Plots.Plot, Dict(:foo => 1, :bar => missing), Dict(:foo => nothing, :baz => 'x')) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| dd = DefaultsDict(Plots.Plot, Dict(:foo => 1, :bar => missing), Dict(:foo => nothing, :baz => 'x')) | |
| dd = DefaultsDict( | |
| Plots.Plot, | |
| Dict(:foo => 1, :bar => missing), | |
| Dict(:foo => nothing, :baz => 'x'), | |
| ) |
src/arg_desc.jl
Outdated
Comment on lines
16
to
18
| :fillrange => (Union{Real,AVec}, "Fills area between fillrange and `y` for line-types, sets the base for `bar`, `sticks` types, and similar for other types."), | ||
| :fillcolor => (ColorType, "Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`."), | ||
| :fillalpha => (Real, "The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor."), |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| :fillrange => (Union{Real,AVec}, "Fills area between fillrange and `y` for line-types, sets the base for `bar`, `sticks` types, and similar for other types."), | |
| :fillcolor => (ColorType, "Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`."), | |
| :fillalpha => (Real, "The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor."), | |
| :fillrange => (Union{Real,AVec}, "Fills area between fillrange and `y` for line-types, sets the base for `bar`, `sticks` types, and similar for other types."), | |
| :fillcolor => (ColorType, "Color of the filled area of path or bar types. `:match` will take the value from `:seriescolor`."), | |
| :fillalpha => (Real, "The alpha/opacity override for the fill area. `nothing` (the default) means it will take the alpha value of fillcolor."), |
src/backends/gr.jl
Outdated
| @@ -1880,14 +1883,14 @@ end | |||
| function gr_draw_contour(series, x, y, z, clims) | |||
| GR.setprojectiontype(0) | |||
| GR.setspace(clims[1], clims[2], 0, 90) | |||
| gr_set_line(get_linewidth(series), get_linestyle(series), get_linecolor(series), series) | |||
| gr_set_line(get_line_width(series), get_line_style(series), get_line_color(series), series) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| gr_set_line(get_line_width(series), get_line_style(series), get_line_color(series), series) | |
| gr_set_line( | |
| get_line_width(series), | |
| get_line_style(series), | |
| get_line_color(series), | |
| series, | |
| ) |
src/backends/inspectdr.jl
Outdated
| color = _inspectdr_mapcolor( | ||
| plot_color(get_markerstrokecolor(series), get_markerstrokealpha(series)), | ||
| plot_color(get_marker_stroke_color(series), get_marker_stroke_alpha(series)), |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| plot_color(get_marker_stroke_color(series), get_marker_stroke_alpha(series)), | |
| plot_color( | |
| get_marker_stroke_color(series), | |
| get_marker_stroke_alpha(series), | |
| ), |
src/backends/unicodeplots.jl
Outdated
| @@ -291,7 +291,10 @@ function _show(io::IO, ::MIME"image/png", plt::Plot{UnicodePlotsBackend}) | |||
| if (l = plt.layout[r, c]) isa GridLayout && size(l) != (1, 1) | |||
| unsupported_layout_error() | |||
| else | |||
| img = UnicodePlots.png_image(plt.o[sps += 1]; pixelsize = 32) | |||
| img = UnicodePlots.png_image(plt.o[sps += 1]; | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| img = UnicodePlots.png_image(plt.o[sps += 1]; | |
| img = UnicodePlots.png_image( | |
| plt.o[sps += 1]; |
src/consts.jl
Outdated
| @@ -69,6 +69,8 @@ const _all_plot_args = _plot_args | |||
| const _all_args = | |||
| union(_lettered_all_axis_args, _all_subplot_args, _all_series_args, _all_plot_args) | |||
|
|
|||
| const _all_segmenting_attributes = Set(_segmenting_vector_attributes ∪ _segmenting_array_attributes) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const _all_segmenting_attributes = Set(_segmenting_vector_attributes ∪ _segmenting_array_attributes) | |
| const _all_segmenting_attributes = | |
| Set(_segmenting_vector_attributes ∪ _segmenting_array_attributes) |
test/test_args.jl
Outdated
| @@ -60,6 +62,9 @@ end | |||
| @test yticks(pl2) == xticks(pl1) | |||
| @test filter(isfinite, pl1[1][1][:x]) == filter(isfinite, pl2[1][1][:y]) | |||
| @test filter(isfinite, pl1[1][1][:y]) == filter(isfinite, pl2[1][1][:x]) | |||
| @test pl1[1][1][:line_color] == RGBA{Float64}(0.0,0.0,0.0,1.0) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test pl1[1][1][:line_color] == RGBA{Float64}(0.0,0.0,0.0,1.0) | |
| @test pl1[1][1][:line_color] == RGBA{Float64}(0.0, 0.0, 0.0, 1.0) |
| explicit::KW | ||
| defaults::KW | ||
| function DefaultsDict{P}(plot_type::Type{P}, explicit::AbstractDict, defaults::AbstractDict) where {P} |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function DefaultsDict{P}(plot_type::Type{P}, explicit::AbstractDict, defaults::AbstractDict) where {P} | |
| function DefaultsDict{P}( | |
| plot_type::Type{P}, | |
| explicit::AbstractDict, | |
| defaults::AbstractDict, | |
| ) where {P} |
| @testset "DefaultsDict" begin | ||
| dd = DefaultsDict(Dict(:foo => 1, :bar => missing), Dict(:foo => nothing, :baz => 'x')) | ||
| dd = DefaultsDict(MyPlot, Dict(:foo => 1, :bar => missing), Dict(:foo => nothing, :baz => 'x')) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| dd = DefaultsDict(MyPlot, Dict(:foo => 1, :bar => missing), Dict(:foo => nothing, :baz => 'x')) | |
| dd = DefaultsDict( | |
| MyPlot, | |
| Dict(:foo => 1, :bar => missing), | |
| Dict(:foo => nothing, :baz => 'x'), | |
| ) |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to split #4489 into smaller PRs, to keep things managable.
So this PR only touches marker and line attributes and aliases.