Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border ticks of framestyle :box #4832

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

lch
Copy link
Contributor

@lch lch commented Oct 10, 2023

Description

As mentioned in Issue #2218 , when using the GR backend with attribute framestyle = :box, there are no ticks presents on the opposite side of border (border depends on attribute mirror). And PR #4488 has not solved the problem and closed the previous issue.

Here I'm providing another small PR trying to fix the problem, which just add missing segements when drawing the plot with attribute framestyle = :box.

Also mentioned by @BeastyBlacksmith in the issue, the behaviour of :box should be like that. However I'm not sure whether it is better to provides some attribute switches to control whether those ticks should be placed on the opposite side.

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?

@BeastyBlacksmith
Copy link
Member

can you run using JuliaFormatter; format(["src", "test"]) to get the formatting right?

@BeastyBlacksmith BeastyBlacksmith merged commit 52183bd into JuliaPlots:master Oct 13, 2023
8 of 14 checks passed
@oidw
Copy link

oidw commented Mar 25, 2024

Hi, is it possible to also have the original behavior (no ticks on the opposite side of border) when setting framestyle = :box?
Or, is there any other method to achieve that (figure with box frame but no ticks on top and right axes)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants