Cap documenter version to "0" #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seem to be breaking changes in Documenter 1.x regarding Documenter.Expanders and code block highlighting in docstrings. This PR proposes to limit the Documenter version to <1.0 as a quick fix until there is time to figure out what has been changed. Alternatively, we could suspend highlighting in docstrings.
j-fu
referenced
this pull request
Oct 3, 2023
* Fix print_script for 1.10 Appearantly, at the time when @generated is evaluated, methods from other packages may not have been compiled yet, so `hasmethod(show, Tuple{IO, MIME{Symbol("text/javascript")}, value})` returns false, and the @generated function print_script throws an error. As the old version worked in 1.9.3, this appears to be the result of subtle changes in precompilation/initialization behavior somewhere between 1.9.3 and 1.10.0-beta2. * Add version discriminator for print_script(::IO, ::MIME,::Any) Keep the old behavior (via @generated) for versions <=1.9.x.
|
Just tried to figure out if I could fix the highlighting instead for the new Documenter, but
This is indeed still the case. so I'd like to keep this PR going as it is together with a new release to be able to use #36 in Pluto notebooks. |
|
Bump this to finally resolve #35 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be breaking changes in Documenter 1.x regarding Documenter.Expanders and code block highlighting in docstrings.
This PR proposes to limit the Documenter version to <1.0 as a quick fix until there is time to figure out what has been changed.
Alternatively, we could suspend highlighting in docstrings.