Use base64url instead of base64 to avoid escaping #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlutoSliderServer uses a lot of base64, for example, in a staterequest:
We currently use the following as the Pluto hash:
Hello world
=>Hello%20world
)And for the bonds data, the same, but without hashing.
The hope was that by URI escaping, we would get legal URLs for base64 data, and additionally, in #29 , legal file names for precomputed states.
But! It turns out that some proxies and some file servers perform URI unescaping before it reaches this package. List of problems:
Solution
This PR uses the
base64url
algorithm instead ofbase64
:TODO
TODO: