Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PlutoTeachingTools.jl #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add PlutoTeachingTools.jl #69

wants to merge 1 commit into from

Conversation

eford
Copy link

@eford eford commented Sep 24, 2024

No description provided.

@fonsp
Copy link
Member

fonsp commented Oct 2, 2024

Thanks for the contribution @eford!

Looks good! Just a couple of comments:

Could you add:

  • an introduction text? For example, it might not be clear that this is a notebook about a package.
  • an introduction to "Robust Local Resources"

Foldable: you could replace this with PlutoUI.details, with the same type signature. This was recently added to PlutoUI and it is very stable JuliaPluto/PlutoUI.jl#288

LaTeX: the difference between latexify_md and wrap_tex and LaTeXString could be more clear. (Maybe different function names?) I think "Now, you can include variables" should be "Now, you can include numerical values".

Ingredients: this does not work in the featured notebook because of the missing module file (especially when people download and run the notebook locally). Since it's more about PlutoLinks than PlutoTeachingTools, perhaps we could remove it from this notebook, and include it in another notebook about code loading?

@fonsp
Copy link
Member

fonsp commented Oct 2, 2024

Presentation mode: maybe you could mention the built-in button for presentation mode? fonsp/Pluto.jl#2660

@eford
Copy link
Author

eford commented Oct 3, 2024

Thanks for the constructive suggestions. I think I can each of those next time I get a chance to tinker with this.

@eford
Copy link
Author

eford commented Oct 3, 2024

Presentation mode: maybe you could mention the built-in button for presentation mode? fonsp/Pluto.jl#2660

Thanks. I either hadn't noticed or forgot.
Should we deprecate present_button() now?

We could also consider deprecating ChooseDisplayMode() and undeprecating WidthOverDocs(). Does anyone else have an opinion on this? I kind of like having both boxes next to each other in ChooseDisplayMode(), but maybe that's just what I've gotten used to.

@eford
Copy link
Author

eford commented Oct 3, 2024

We could also consider deprecating ChooseDisplayMode() and undeprecating WidthOverDocs(). Does anyone else have an opinion on this? I kind of like having both boxes next to each other in ChooseDisplayMode(), but maybe that's just what I've gotten used to.

I'll copy this into a new issue in PlutoTeachingTools.

@fonsp
Copy link
Member

fonsp commented Oct 3, 2024

Happy to hear! About ChooseDisplayMode vs WidthOverDocs: no opinion about deprecation, just that I'm happy that the package provides the full-width option. It's hard to implement properly in Pluto but now people can already use it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants