Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for non-contiguous PyArrays, fix f_contiguous, simplify copy(::PyArray) #623

Merged
merged 4 commits into from
Dec 14, 2018

Conversation

JobJob
Copy link
Contributor

@JobJob JobJob commented Dec 12, 2018

Changes by commit

  1. Add support for non-contiguous PyArrays: Restore support for non-contiguous PyArrays (I think they used to work before PyArray conversion speedups and PyArrayFromBuffer #487?)
  2. Fix f_contiguous for 1d arrays: without this non-contiguous 1d PyArrays could have the f_contig flag set incorrectly to true. This would cause an incorrect conversion to julia for such arrays with a convert(PyAny, non_contig_1d_array) (see the [1,0,1,0] example in Use native sizes by default when parsing buffer format string #621/the "1d non-contiguous" testset in this PR)
  3. Simplify Copy(::PyArray): With f_contiguous correct for 1d, copy(::PyArray) could be simplified

@JobJob JobJob force-pushed the non-contig-pyarrays branch from 6cbec28 to 8e5be56 Compare December 12, 2018 08:32
@JobJob
Copy link
Contributor Author

JobJob commented Dec 12, 2018

force-push

Naughty naughty...

@stevengj stevengj merged commit 093342b into JuliaPy:master Dec 14, 2018
@stevengj
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants