Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update juliacall.md #446

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Update juliacall.md #446

merged 1 commit into from
Jan 31, 2024

Conversation

MilesCranmer
Copy link
Contributor

@MilesCranmer MilesCranmer commented Jan 28, 2024

Aside: Shouldn't this just be the default though? I feel like if I run

pip install git+https://github.com/JuliaPy/PythonCall.jl

it should result in me getting the development version of both juliacall and PythonCall.jl.

@cjdoris cjdoris merged commit 3ec4267 into JuliaPy:main Jan 31, 2024
7 of 13 checks passed
@cjdoris
Copy link
Collaborator

cjdoris commented Jan 31, 2024

Thanks for the correction!

@cjdoris
Copy link
Collaborator

cjdoris commented Jan 31, 2024

I agree it would be nice to do this automatically. The issue is that the installation of PythonCall is not handled by pip, it is handled by JuliaPkg (which JuliaCall depends on for package management). So JuliaPkg needs to somehow know that we are running the dev version of JuliaCall, and then switch behaviour accordingly. I don't know a robust way to check if a package is in "dev mode". I'm not even sure what that means.

An alternative would be to have juliapkg.json in the repo actually be the dev one, and change it whenever I make a release. But that would be extremely error prone.

A simple solution would simply to have an env var like PYTHON_JULIAPKG_DEV=juliacall (or Python flag -X juliapkg-dev=juliacall), and then for these packages JuliaPkg looks for juliapkg-dev.json instead of juliapkg.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants