Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unexported variables to module's __dir__ #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtikekar
Copy link

@mtikekar mtikekar commented Oct 26, 2018

__dir__ should have names of all variables and not just the exported ones like in __all__

names.update(self.__all__)

juliapath = remove_prefix(self.__name__, "julia.")
julianames = set(self._julia.eval("names({}; all=true)".format(juliapath)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

names({}; all=true) does not work with Julia 0.6.

@tkf
Copy link
Member

tkf commented Oct 26, 2018

Thanks for the PR! I think it's easier to do this after dropping Julia 0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants