Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Base.require instead of using in more places #407

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Aug 3, 2020

Commit Message

Use Base.require instead of using in more places (#407)

This way, PyJulia can work in more strict setup (e.g., customized
JULIA_LOAD_PATH).

This way, PyJulia can work in more strict setup (e.g., customized
`JULIA_LOAD_PATH`).
mergify[bot]
mergify bot previously approved these changes Aug 3, 2020
@mergify mergify bot dismissed their stale review August 3, 2020 00:20

Pull request has been modified.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   87.51%   87.52%   +0.01%     
==========================================
  Files          39       39              
  Lines        2234     2237       +3     
==========================================
+ Hits         1955     1958       +3     
  Misses        279      279              
Impacted Files Coverage Δ
src/julia/core.py 82.12% <100.00%> (+0.05%) ⬆️
src/julia/utils.py 93.75% <100.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fa44a...2576f38. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Aug 3, 2020

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Aug 3, 2020

Command refresh: success

@mergify mergify bot merged commit 573dc13 into JuliaPy:master Aug 3, 2020
@tkf tkf deleted the require branch August 3, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant