Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong creation of empty polygon/polytope #319

Closed
schillic opened this issue Apr 5, 2018 · 0 comments
Closed

Wrong creation of empty polygon/polytope #319

schillic opened this issue Apr 5, 2018 · 0 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@schillic
Copy link
Member

schillic commented Apr 5, 2018

# wrong
HPolytope{N}() where {N<:Real} = HPolytope{N}(Vector{N}(0))

# right
HPolytope{N}() where {N<:Real} = HPolytope{N}(Vector{LinearConstraint{N}}(0))

The old code works, probably because Julia internally converts, but needs one more allocation.

# wrong
julia> @time h = HPolytope{Int}()
  0.000064 seconds (7 allocations: 336 bytes)
LazySets.HPolytope{Int64}(LazySets.HalfSpace{Int64}[])

# right
julia> @time h = HPolytope{Int}()
  0.000064 seconds (6 allocations: 256 bytes)
LazySets.HPolytope{Int64}(LazySets.HalfSpace{Int64}[])
@schillic schillic added the bug 🐛 Something isn't working label Apr 5, 2018
@schillic schillic self-assigned this Apr 5, 2018
schillic added a commit that referenced this issue Apr 5, 2018
#319 - Wrong creation of empty polygon/polytope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant