-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1352 - Disambiguation for lazy intersection of polyhedra #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point about unboundedness, but as you said here we already have this issue in the other methods because we cannot statically detect boundedness of general LazySet
s.
The only alternative I see is to manually wrap the constraints in an HPolytope
, thereby expressing boundedness. The user has to deal with the case that the intersection is unbounded either way.
So from a usability point of view I would say we can add your disambiguation.
Maybe we should assert boundedness of LazySets.jl/src/Approximations/overapproximate.jl Lines 360 to 380 in b451d0a
|
Co-Authored-By: Christian Schilling <schillic@informatik.uni-freiburg.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the remaining ambiguities.
Closes #1352.
Marking this as WIP since i consider it still under discussion.