Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1539 - Ignore constraints with zero normal vector #1542

Merged
merged 2 commits into from
Jul 30, 2019
Merged

#1539 - Ignore constraints with zero normal vector #1542

merged 2 commits into from
Jul 30, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Jul 30, 2019

Closes #1539.

@mforets mforets requested a review from schillic July 30, 2019 20:18
schillic
schillic approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also @assert b >= zero(N) in the continue case.

@mforets mforets merged commit a932d9b into master Jul 30, 2019
@schillic schillic deleted the mforets/1539 branch July 31, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
JuliaReachDays1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle constraints with zero normal direction in conversions
2 participants
@mforets @schillic