Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1606 - Revise lazy-map constructors #1627

Merged
merged 6 commits into from
Aug 30, 2019
Merged

#1606 - Revise lazy-map constructors #1627

merged 6 commits into from
Aug 30, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Aug 20, 2019

Closes #1606.

  • LinearMap
  • AffineMap
  • ResetMap
  • ExponentialMap
  • I skipped ExponentialProjectionMap because it is not used and does not have the bug.

@schillic schillic force-pushed the schillic/1606 branch 2 times, most recently from 01f5075 to 0cfc930 Compare August 22, 2019 18:47
@schillic schillic changed the title WIP #1606 - Revise lazy-map constructors #1606 - Revise lazy-map constructors Aug 22, 2019
@schillic schillic requested a review from mforets August 22, 2019 19:23
docs/src/lib/operations.md Outdated Show resolved Hide resolved
src/LinearMap.jl Show resolved Hide resolved
src/AffineMap.jl Outdated Show resolved Hide resolved
src/AffineMap.jl Outdated Show resolved Hide resolved
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice docs 📖

src/LinearMap.jl Show resolved Hide resolved
@schillic schillic requested a review from mforets August 30, 2019 19:11
@mforets mforets merged commit 8fb4a15 into master Aug 30, 2019
@mforets mforets deleted the schillic/1606 branch August 30, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dispatch from aliases to underlying functions
2 participants