Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1662 - Dimensional check in zonotope constructor #1664

Merged
merged 2 commits into from
Sep 3, 2019
Merged

#1662 - Dimensional check in zonotope constructor #1664

merged 2 commits into from
Sep 3, 2019

Conversation

SebastianGuadalupe
Copy link
Member

Closes #1662.

schillic
schillic reviewed Sep 1, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case (@test_throws AssertionError Zonotope(...)), please?

src/Zonotope.jl Outdated Show resolved Hide resolved
@mforets
Copy link
Member

mforets commented Sep 1, 2019

@SebastianGuadalupe can you rebase w/master?

@schillic
Copy link
Member

schillic commented Sep 2, 2019

To fix the test failure, please fix this line:

LazySets.jl/test/check_method_ambiguity_binary.jl

Line 64 in 38cae57

Zonotope(zeros(1), hcat([1.; 2.]))

It should be:

        Zonotope(zeros(1), [1. 2.;])

@schillic schillic requested a review from mforets September 3, 2019 13:51
mforets
mforets approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mforets mforets merged commit 7499f06 into master Sep 3, 2019
@mforets mforets deleted the sebastianguadalupe/1662 branch September 3, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dimensional check in zonotope constructor
3 participants
@SebastianGuadalupe @mforets @schillic