#1446 - Print error message if required external package is missing #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Dec 3, 2019
schillic
force-pushed
the
schillic/1446
branch
from
d1b1cca to
25a4898
Compare
schillic
force-pushed
the
schillic/1446
branch
2 times, most recently
from
79b0237 to
b0eabf3
Compare
schillic
force-pushed
the
schillic/1446
branch
from
fd53765 to
2e32a2f
Compare
mforets
reviewed
Dec 12, 2019
|
@schillic Have you tried the plot3d function after this change? (I haven't, and since we don't test it..) |
Yes, it still works. |
|
Ok, thanks. |
schillic
force-pushed
the
schillic/1446
branch
from
2e32a2f to
cc4097f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1446.
I defined new methods outside the
Requireswrappers for better error printing. Alternatively, we could sometimes remove theRequireswrappers altogether and instead use ourrequirehelper function.The only cases I did not add are functions that are clearly package specific (
default_cddlib_backend,default_polyhedra_backend,default_lp_solver_polyhedra, andpolyhedron).