Add polynomial zonotope #184

mforets · 2018-01-23T22:51:00Z

schillic · 2018-01-24T07:35:54Z

src/PolynomialZonotope.jl

+
+Abstract type for non-convex sets.
+"""
+abstract type AbstractNonConvexSet{N} end


Let us do this properly in a separate PR:

Move to a new file (and maybe rename to AbstractSet or even Set or LazySet).¹

Make LazySet inherit from this new type and rename to AbstractConvexSet or just ConvexSet.¹ This basically means changing every file, so better merge most PRs first.

Make UnionSet inherit from this new type and include it (there are already some unit tests).

Since this is a breaking change, we should probably do it before releasing 1.1.0.

¹This will be something we and the user will write a lot, so a short name would be preferable.

outsourced to #185

Since this is a breaking change, we should probably do it before releasing 1.1.0.

2.0 iiuc since that would be an incompatible API change (https://semver.org/)

ok i've updated to <: LazySet{N}, what i should have done in the 1st place, at least 'till we resolve the approach for #185.

#185 was created for this issue (only later). You could not have done that before ;)

schillic · 2018-01-24T07:36:18Z

src/PolynomialZonotope.jl

+
+- `c`  -- starting point
+- `E`  -- multi-indexed generators such that *all* indices have the same value
+- `F`  -- multi-indexed generators such that *not all* indices are the same value


"are" → "have"

schillic · 2018-01-24T07:36:45Z

src/PolynomialZonotope.jl

+
+### Notes
+
+Polynomial zonotope were introduced by M. Althoff in *Reachability analysis of nonlinear


"zonotope" → "zonotopes"

schillic · 2018-01-24T07:37:39Z

src/PolynomialZonotope.jl

+abstract type AbstractNonConvexSet{N} end
+
+"""
+    PolynomialZonotope{N<:Real} <: AbstractNonConvexSet{N}


Here you have N<:Real, but not in the actual struct definition.

schillic · 2018-01-24T07:37:59Z

src/PolynomialZonotope.jl

+
+- `pz` -- polynomial zonotope
+"""
+dim(pz::PolynomialZonotope) = length(pz.c)


Add output docs and output type?

schillic · 2018-01-24T07:38:27Z

src/PolynomialZonotope.jl

+The polynomial order, defined as the maximal power of the scalar factors ``β_i``.
+Usually denoted ``η``.
+"""
+polynomial_order(pz::PolynomialZonotope) = length(pz.E)


Add output type?

schillic · 2018-01-24T07:38:47Z

src/PolynomialZonotope.jl

+
+## Output
+
+The polynomial order, defined as the number of generators divided by the ambient


Drop "polynomial".

schillic · 2018-01-24T07:39:08Z

src/PolynomialZonotope.jl

+The polynomial order, defined as the number of generators divided by the ambient
+dimension.
+"""
+function order(pz::PolynomialZonotope)


Add output type?

mforets · 2018-01-24T11:20:31Z

To-do:

support vector << see Support vector computation for a polynomial zonotope #239
zonotope_overapproximation << see Overapproximate polynomial zonotope with zonotope #230
polytope_overapproximation << see Overapproximate polynomial zonotope with zonotope #230
convex hull << future issue
cartesian product << future issue
linear map
minkowski sum of pz and z
add math to docstring
add to docs

schillic

LGTM, although I did not check the maths :)

schillic · 2018-02-13T19:09:10Z

src/PolynomialZonotope.jl

+
+### Input
+
+- `α` -- polynomial zonotope


scalar factor?

scale factor 👍

schillic · 2018-02-13T19:09:46Z

src/PolynomialZonotope.jl

+
+## Output
+
+Polynomial zonotope such that its center and generators are multiples of those


Above you called the center "starting point".

schillic · 2018-02-13T19:11:02Z

src/PolynomialZonotope.jl

+
+Polynomial zonotope.
+"""
+function minkowski_sum(pz::PolynomialZonotope, z::Zonotope)


Add the symmetric method? It can fall back to this one.

good. i imagine some macro for lazy people (like us) used as:

@symmetric function minkowski_sum(pz::PolynomialZonotope, z::Zonotope) c = pz.c + z.center G = [G z.generators] return PolynomialZonotope(c, pz.E, pz.F, G) end

and builds the new symmetric function using this one.

schillic · 2018-02-13T19:12:07Z

test/unit_PolynomialZonotope.jl

+
+# type-specific concrete methods
+scale(N(0.5), p)
+linear_map(N[1.0 2.0; 2.0 5.0], p)


Add a unit test for minkowski_sum?

ok. i plan to add proper @test's when with #230 gets in

schillic · 2018-02-13T21:07:28Z

I added "support vector" to the open tasks list above - do not forget it ;)

schillic reviewed Jan 24, 2018

View reviewed changes

add lazysets and polynomial zonotope

c9a5be6

mforets force-pushed the mforets/polynomial_zonotope branch from 9b66fb1 to c9a5be6 Compare February 2, 2018 20:02

mforets added 4 commits February 2, 2018 17:08

add stab for sigma

5633e91

typo

da2371b

fix scale and linear map

002c93e

extend the doctest

de942e8

mforets mentioned this pull request Feb 10, 2018

Overapproximate polynomial zonotope with zonotope #230

Closed

update branch

53a7b39

mforets added this to the v1.2.0 milestone Feb 13, 2018

mforets added 3 commits February 13, 2018 13:45

add docs

f014319

update PolynomialZonotope

4d4a9aa

update tests

a965b30

mforets changed the title ~~[WIP] add polynomial zonotope~~ Add polynomial zonotope Feb 13, 2018

schillic approved these changes Feb 13, 2018

View reviewed changes

mforets added 2 commits February 13, 2018 20:19

update a jldoctest

b887d45

Merge branch 'master' into mforets/polynomial_zonotope

a7e1658

mforets merged commit f4c5600 into master Feb 14, 2018

mforets deleted the mforets/polynomial_zonotope branch February 14, 2018 01:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add polynomial zonotope #184

Add polynomial zonotope #184

mforets commented Jan 23, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

mforets Jan 24, 2018

mforets Feb 2, 2018

schillic Feb 3, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

schillic Jan 24, 2018

mforets commented Jan 24, 2018 •

edited

Loading

schillic left a comment

schillic Feb 13, 2018

mforets Feb 13, 2018

schillic Feb 13, 2018

schillic Feb 13, 2018

mforets Feb 13, 2018

schillic Feb 13, 2018

mforets Feb 13, 2018

schillic commented Feb 13, 2018


		### Notes

		Polynomial zonotope were introduced by M. Althoff in *Reachability analysis of nonlinear


		## Output

		The polynomial order, defined as the number of generators divided by the ambient


		## Output

		Polynomial zonotope such that its center and generators are multiples of those

Add polynomial zonotope #184

Add polynomial zonotope #184

Conversation

mforets commented Jan 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mforets commented Jan 24, 2018 • edited Loading

schillic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

schillic commented Feb 13, 2018

mforets commented Jan 24, 2018 •

edited

Loading