Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#63 - refactoring LazySet & an_element default implementation #216

Merged
merged 6 commits into from
Feb 3, 2018
Merged

#63 - refactoring LazySet & an_element default implementation #216

merged 6 commits into from
Feb 3, 2018

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 2, 2018

Closes #63.

@schillic schillic requested a review from mforets February 2, 2018 11:05
@mforets
Copy link
Member

mforets commented Feb 2, 2018

the functions σ and dim also make sense for non-convex.

how about creating a new abstract function isconvex?

@schillic
Copy link
Member Author

schillic commented Feb 2, 2018

Yes, I did not want to introduce the non-abstract type in this PR.

mforets
mforets approved these changes Feb 3, 2018
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@schillic schillic merged commit 2a5f52f into master Feb 3, 2018
@schillic schillic deleted the schillic/63 branch February 3, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets