Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#293 - Revise output type annotations #294

Merged
merged 5 commits into from
Mar 14, 2018
Merged

#293 - Revise output type annotations #294

merged 5 commits into from
Mar 14, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 13, 2018

Closes #293

schillic
schillic reviewed Mar 13, 2018
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, σ for MinkowskiSumArray will always return a Vector. So we will crash if we have, say, a ConvexHull of a MinkowskiSumArray.

src/Ball1.jl
@@ -121,7 +121,7 @@ Return the support vector of a ball in the 1-norm in a given direction.

Support vector in the given direction.
"""
function σ(d::AbstractVector{N}, B::Ball1{N})::AbstractVector{N} where {N<:Real}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs have not been updated.

@schillic
Copy link
Member

This branch actually made some of the benchmarks slightly slower:

  • Heat: 12 vs. 9.15 seconds
  • ISS: 2.47 vs. 1.94 seconds
  • Beam: 33 vs. 28 seconds
  • MNA1: 100 vs. 90 seconds
  • FOM: 7.45 vs. 6.64 seconds

@mforets
Copy link
Member Author

mforets commented Mar 14, 2018

I'll remove the type annotations then.

@schillic schillic merged commit b3c56c3 into master Mar 14, 2018
@schillic schillic deleted the mforets/293 branch March 14, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic