Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#559 - Tohrep, tovrep for concrete polytopes #603

Merged
merged 3 commits into from
Sep 3, 2018
Merged

#559 - Tohrep, tovrep for concrete polytopes #603

merged 3 commits into from
Sep 3, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Sep 2, 2018 •
edited
Loading

Closes #559.

@mforets mforets changed the title Tohrep, tovrep for concrete polytopes #559 - Tohrep, tovrep for concrete polytopes Sep 2, 2018
schillic
schillic requested changes Sep 3, 2018
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a unit test that should be adapted.

src/HPolytope.jl Outdated
The `VPolytope` which is the vertex representation of the given polytope
in constraint representation.
"""
function tohrep(P::HPolytope; backend=CDDLib.CDDLibrary())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tovrep

@schillic
Copy link
Member

schillic commented Sep 3, 2018

Should we also add the no-op versions (tohrep for HPolytope etc.)?

@mforets mforets merged commit 4b20264 into master Sep 3, 2018
@mforets mforets deleted the mforets/559 branch September 3, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic