Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comparisons in floating point #929

Merged
merged 27 commits into from
Jan 15, 2019
Merged

Add comparisons in floating point #929

merged 27 commits into from
Jan 15, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Nov 26, 2018

No description provided.

@mforets mforets mentioned this pull request Nov 29, 2018
Closed
@mforets mforets changed the title WIP comparisons.jl Add comparisons in floating point Dec 9, 2018
@mforets mforets requested a review from schillic December 9, 2018 23:07
schillic
schillic reviewed Dec 10, 2018
View reviewed changes
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Outdated Show resolved Hide resolved
src/comparisons.jl Show resolved Hide resolved
mforets and others added 12 commits January 11, 2019 22:21
@mforets
Merge branch 'master' into mforets/comparisons
353bed3
@schillic @mforets
Update src/comparisons.jl
caf069b 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
92715b7 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
3af8641 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
e8e64d0 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
56fa695 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
40705ed 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
0514c18 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
610d8bf 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
88b112c 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
3f2556e 
Co-Authored-By: mforets <mforets@gmail.com>
@mforets
add note on Polyhedra.jl
5ce8d37
@mforets
Copy link
Member Author

mforets commented Jan 12, 2019 •
edited
Loading

(Note: This file is inspired from Polyhedra.jl, see this file. I've added this note on the beginning of src/comparisons.jl.)

schillic
schillic reviewed Jan 12, 2019
View reviewed changes
src/comparisons.jl Outdated Show resolved Hide resolved
mforets and others added 7 commits January 12, 2019 21:25
@mforets
fix isapproxzero
88ff7ca
@schillic @mforets
Update src/comparisons.jl
382d3f3 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
87c04a7 
Co-Authored-By: mforets <mforets@gmail.com>
@mforets
fix passing atol
5174d24
@mforets
update docstrings in comparisons
625c1e0
@schillic @mforets
Update src/comparisons.jl
c1f6a08 
Co-Authored-By: mforets <mforets@gmail.com>
@schillic @mforets
Update src/comparisons.jl
0db7458 
Co-Authored-By: mforets <mforets@gmail.com>
schillic
schillic approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After CI has finished, there will still be some untested methods (for mixed numeric types, see here (they are not marked in red)). Can you add tests for them as well?

@mforets mforets merged commit 87c4016 into master Jan 15, 2019
@mforets mforets deleted the mforets/comparisons branch January 15, 2019 11:19
@schillic schillic mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic