-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#605 - Function for checking boundedness #956
Conversation
a27c5a9
to
3ca5a7e
Compare
May i suggest to rename (Comparing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏 👏 👏
Do you agree that for |
Co-Authored-By: schillic <schillic@informatik.uni-freiburg.de>
02afdd4
to
11cec29
Compare
Yes, it follows from the invertibility of Indeed, suppose by contradiction that the set We can use this condition in |
Closes #605.
This PR adds
isbounded(::Set)
.There is a default implementation (that uses
isbounded_unit_dims
), but only the implementations ofExponentialProjectionMap
,HPolyhedron
,Intersection(Array)
, andLinearMap
may fall back to that default if some sufficient/necessary checks fail. For the other set types, the check is trivial (or recursive for operations).Some tests do not work before merging #940, so they currently throw an error. Whatever gets merged last has to update those tests.@mforets: Can you please check the implementations for
LinearMap
,ExponentialMap
, andExponentialProjectionMap
if they are correct or if they can be improved?