Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: CoordinateConventions v1.0.2 #112074

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jul 30, 2024

Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@aplavin
Copy link
Contributor

aplavin commented Jul 30, 2024

Tbh, even after looking at readme and docs, I have absolutely no idea what kind of coordinates this package is about, or what field at all. Not even talking about the "conventions" themselves :)

This could really use a few sentences of simple explanation... [noblock]

@bclyons12
Copy link

[noblock]

@aplavin It's an implementation of COCOS - Coordinate Conventions commonly used in fusion research. We will add this to the documentation.
Paper: O. Sauter and S. Y Medvedev, "Tokamak Coordinate Conventions: COCOS", Comput. Phys. Commun. 184 (2013) 293

cc: @orso82

@orso82
Copy link

orso82 commented Jul 31, 2024

[noblock]

Good point. I have updated the README.md and online documentation accordingly

UUID: 7204ce3a-f536-43d2-be4a-fbed74e90d86
Repo: https://github.com/ProjectTorreyPines/CoordinateConventions.jl.git
Tree: 21526fff87d3552b6fe4230a7d541d9fcecd0317

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-coordinateconventions-7204ce3a-v1.0.2-f2ba45726c branch from 7480a7c to e1c90cc Compare July 31, 2024 16:40
JuliaRegistrator referenced this pull request in ProjectTorreyPines/CoordinateConventions.jl Jul 31, 2024
@JuliaTagBot JuliaTagBot merged commit b3385d1 into master Aug 2, 2024
11 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-coordinateconventions-7204ce3a-v1.0.2-f2ba45726c branch August 2, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants