Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Fortran90Namelists v0.1.0 #116638

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 8fb689aa-71ff-4044-8071-0cffc910b57d
Repo: https://github.com/anchal-physics/Fortran90Namelists.jl.git
Tree: 31dbc52282ad367dc807d4f242825d52a56abec2

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Package name similar to 1 existing package.
    1. Similar to PyFortran90Namelists. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@anchal-physics
Copy link

[noblock] Requesting override of package name similarity. This package is indeed supposed to provide same functionality as PyFortran90Namelists but without using the python modules in the backend. This is a pure julia implementation and thus it makes sense for it to have same name without the Py suffix.

@singularitti
Copy link
Contributor

singularitti commented Oct 6, 2024

Hi @anchal-physics, I really appreciate the work you've done in forking and modifying Fortran90Namelists.jl. It's great to see that others find the package useful and are contributing to the ecosystem.

I wanted to ask if you'd consider giving your fork a different name. The main reason is that I may implement a new version of the parser with some structural changes in the future, and I’d like to keep the original name available for that. Additionally, since your package is intended to be minimally maintained, a new name would help distinguish between our versions and avoid any potential confusion for users.

One suggestion could be FortranNamelistsParser.jl, which reflects the purpose of the package while differentiating it from the original. Let me know your thoughts, and thanks again for your contributions!
[noblock]

@anchal-physics
Copy link

@singularitti Thanks for your comment and suggestion. I agree with you and will wait for your improved Fortran90Namelists.jl package. For now, I've renamed this package to FortranNamelistParser.jl and it has been accepted as new package in Julia Registry on this pull request: #116786 . This merge request can be ignored and closed now without merging. Thanks.

@singularitti
Copy link
Contributor

That's great! Thank you! @anchal-physics

@goerz goerz closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants