Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: DUNEatLapp v1.0.0 #116887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: fdff9d19-a718-4541-8df3-3ed0c3979067
Repo: https://github.com/MaelMartin17/DUNEatLapp.jl.git
Tree: 50aad67a213480bba2665b05a2700a512f6d8db0

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Oct 9, 2024

Thank you for submitting your package. However, it does not seem ready for registration yet. Please see the FAQ.

In the tagged commit, the package is empty. Since we do not allow placeholder registrations, it will not be possible to merge that. More generally, the requirements for registering an initial v0.1 are:

  • Must have a name that is appropriate for the scope of the package
  • Must have some non-trivial functionality (no "placeholder" packages)
  • Must have a README that explains the purpose of the package and gives a basic usage example (or a link to documentation that is sufficient to figure out how to get started)

Since you don't have anything in the README, it's unclear whether the current package name is appropriate.

With 1.0, in addition to that,

  • Must define the stable API. That generally means complete documentation.
  • Must have tests with reasonable coverage (on the order of 80%). Otherwise, there's no way to know if the package actually implements its API correctly
  • Should somewhat reasonably fill the described scope of the package. No major gaps in functionality.

Your package is clearly not at the 1.0 stage yet, so you should register it with an initial version 0.1 instead, after adding more functionality and a more complete README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants