Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: GhpGhx v0.1.0 #64044

Closed
wants to merge 1 commit into from

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jul 11, 2022

JuliaRegistrator referenced this pull request in NREL/GhpGhx.jl Jul 11, 2022
Also, there was a case insensitivity issue with a previous namechange from GHPGHX to GhpGhx
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch July 11, 2022 20:38 Inactive
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • No licenses detected in the package's top-level folder. An OSI-approved license is required.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

UUID: 7ce85f02-24a8-4d69-a3f0-14b5daa7d30c
Repo: https://github.com/NREL/GhpGhx.jl.git
Tree: 19a4afe42a79f22612478a87d9d938c6a5087af2

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/ghpghx/7ce85f02/v0.1.0 branch from 77feee0 to b590cc9 Compare July 11, 2022 20:48
JuliaRegistrator referenced this pull request in NREL/GhpGhx.jl Jul 11, 2022
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch July 11, 2022 20:49 Inactive
@Bill-Becker
Copy link

This package is a dependency of an open source energy modeling tool REopt.jl, but this requires a slightly more restricted license that is defined by its LICENSE.md. Can we please get an exception to the OSI-approved license since this supports the open source REopt.jl?

@ericphanson
Copy link
Member

Sorry, we can’t make exceptions. Quoting from @giordano

this registry is maintained by volunteers, we don't have a legal team that can thoroughly review any added clause, as simple as it may seem to you. Restriction of use (like no commercialisation), however, often goes against some definitions of open source software (it certainly violates one of the freedoms in the definition of free software). Simply using OSI-approved licenses with no added custom clauses is the best way for us to ensure we have packages legally sounding license.

#31549 (comment)

The following comment also looks relevant here as well:

I will add here that any "no commercialization" clause is almost certain to conflict with the GPL: the GPL requires that the derived work be available under terms compatible with the GPL, which guarantees a wide range of freedoms, regardless of the nature of the application. Since Julia by default ships with GPL libraries, it is very likely that any work derived from a package with this license would be illegal. While it's probably ok to have the end user load the package themselves, it is likely that any application that includes the package would not be legal. It would be necessary to compile a no-GPL version of Julia from source in order to legally create a work derived from the package.

#31549 (comment)

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Aug 12, 2022
@Bill-Becker
Copy link

@ericphanson Thank you for the feedback; we've found a workaround with Requires.jl that allows this unregistered package to be a conditional dependency of the registered package. This requires users of the registered package to "add [GhpGhx.jl]" to their project environment in order to use those certain capabilities in the registered package. I will close this PR.

@ericphanson ericphanson deleted the registrator/ghpghx/7ce85f02/v0.1.0 branch August 16, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants