-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: GhpGhx v0.1.0 #64044
New package: GhpGhx v0.1.0 #64044
Conversation
JuliaRegistrator
commented
Jul 11, 2022
•
edited
Loading
edited
- Registering package: GhpGhx
- Repository: https://github.com/NREL/GhpGhx.jl
- Created by: @Bill-Becker
- Version: v0.1.0
- Commit: 987dc6645abe34af7e10c49f78c093f0b86bef8a
- Reviewed by: @Bill-Becker
- Reference: NREL/GhpGhx.jl@987dc66#commitcomment-78239321
- Description: This package is used for sizing a ground heat exchanger to serve the specified heating and cooling loads. This package is called by REopt.jl when GHP is considered in a REopt evaluation.
Also, there was a case insensitivity issue with a previous namechange from GHPGHX to GhpGhx
Your
Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human. After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1 If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
UUID: 7ce85f02-24a8-4d69-a3f0-14b5daa7d30c Repo: https://github.com/NREL/GhpGhx.jl.git Tree: 19a4afe42a79f22612478a87d9d938c6a5087af2 Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
77feee0
to
b590cc9
Compare
This package is a dependency of an open source energy modeling tool REopt.jl, but this requires a slightly more restricted license that is defined by its LICENSE.md. Can we please get an exception to the OSI-approved license since this supports the open source REopt.jl? |
Sorry, we can’t make exceptions. Quoting from @giordano
The following comment also looks relevant here as well:
|
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
@ericphanson Thank you for the feedback; we've found a workaround with Requires.jl that allows this unregistered package to be a conditional dependency of the registered package. This requires users of the registered package to "add [GhpGhx.jl]" to their project environment in order to use those certain capabilities in the registered package. I will close this PR. |