Restrict StaticArrays.jl @v1.5- to Julia v1.10- #86950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
changed the title
giordano
reviewed
Jul 15, 2023
| @@ -1,10 +1,19 @@ | |||
| ["0-0.10"] | |||
| julia = ["0.7", "1"] | |||
| julia = ["0.7", "1-1.10"] | |||
There was a problem hiding this comment.
This doesn't match the title of the PR, you're allowing Julia v1.10, or am I missing something?
There was a problem hiding this comment.
You're right. I thought we might include the AbstractTriangular commit, which removed the second type parameter in v1.10, but I guess we are not (it would need to get backported), so I changed it accordingly.
dkarrasch
changed the title
giordano
reviewed
Jul 15, 2023
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
giordano
reviewed
Jul 15, 2023
| ["0.11"] | ||
| julia = "1-1.10" | ||
|
|
||
| ["0.12-0"] | ||
| julia = "1" |
There was a problem hiding this comment.
Just to confirm, this version is compatible with Julia v1.11+?
There was a problem hiding this comment.
Yes, we backported the relevant commit to v0.12.5 or so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vtjnash Is this how it's done? Related to JuliaLang/julia#26307