Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JLD2 julia compat #93505

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Fix JLD2 julia compat #93505

merged 6 commits into from
Oct 16, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 16, 2023 •
edited
Loading

Avoid

ERROR: LoadError: type DataType has no field size
Stacktrace:
 [1] getproperty(x::Type, f::Symbol)
   @ Base ./Base.jl:32
 [2] top-level scope
   @ ~/.julia/packages/JLD2/qncOK/src/data/number_types.jl:14

@IanButterworth IanButterworth temporarily deployed to stopwatch October 16, 2023 17:43 — with GitHub Actions Inactive
IanButterworth
IanButterworth commented Oct 16, 2023
View reviewed changes
J/JLD2/Compat.toml Outdated Show resolved Hide resolved
IanButterworth
IanButterworth commented Oct 16, 2023
View reviewed changes
J/JLD2/Compat.toml Outdated Show resolved Hide resolved
@IanButterworth IanButterworth temporarily deployed to stopwatch October 16, 2023 17:51 — with GitHub Actions Inactive
@IanButterworth IanButterworth mentioned this pull request Oct 16, 2023
Merged
IanButterworth
IanButterworth commented Oct 16, 2023
View reviewed changes
J/JLD2/Compat.toml Outdated Show resolved Hide resolved
@IanButterworth IanButterworth temporarily deployed to stopwatch October 16, 2023 17:53 — with GitHub Actions Inactive
IanButterworth
IanButterworth commented Oct 16, 2023
View reviewed changes
J/JLD2/Compat.toml Outdated Show resolved Hide resolved
@IanButterworth IanButterworth temporarily deployed to stopwatch October 16, 2023 17:59 — with GitHub Actions Inactive
@IanButterworth IanButterworth temporarily deployed to stopwatch October 16, 2023 18:21 — with GitHub Actions Inactive
@giordano giordano temporarily deployed to stopwatch October 16, 2023 18:53 — with GitHub Actions Inactive
@giordano
Copy link
Member

For context, JLD2 used to access internal fields of Julia's datastructures, which was broken in version v1.9: JuliaIO/JLD2.jl#428. This was fixed by JuliaIO/JLD2.jl#438, included in JLD2 v0.4.28+, but until now older versions are still allowed to be installed on Julia v1.9+, so this PR makes it impossible to install JLD2 v0.4.27- on Julia v1.9+, adding a compatibility cap to julia v1.8.

@giordano giordano marked this pull request as ready for review October 16, 2023 18:58
@giordano giordano merged commit 419cf5c into master Oct 16, 2023
12 checks passed
@giordano giordano deleted the ib/JLD2_compat branch October 16, 2023 19:00
IanButterworth added a commit that referenced this pull request Oct 16, 2023
@IanButterworth
Revert "Cap compatibility of old versions of JLD2 to julia v1.8 (#93505…
b587339 
…)"

This reverts commit 419cf5c.
@IanButterworth IanButterworth mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compat fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanButterworth @giordano