Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp GoToTargetUndirected & GoToTargetDirected #159

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Remove old GoToTargetUndirected and GoToTargetDirected.
  2. Add new GoToTargetUndirectedModule.GoToTargetUndirected and GoToTargetDirectedModule.GoToTargetDirected.
  3. Update tests.
  4. Update README.

Here is how the new environments look:

GoToTargetUndirectedModule.GoToTargetUndirected:

go_to_target_undirected

GoToTargetDirectedModule.GoToTargetDirected:

go_to_target_directed

@codecov-commenter
Copy link

Codecov Report

Merging #159 (609315e) into master (9a2f104) will decrease coverage by 0.69%.
The diff coverage is 79.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   71.03%   70.33%   -0.70%     
==========================================
  Files          27       28       +1     
  Lines        2479     2488       +9     
==========================================
- Hits         1761     1750      -11     
- Misses        718      738      +20     
Impacted Files Coverage Δ
src/envs/envs.jl 72.72% <ø> (ø)
src/envs/go_to_target_directed.jl 72.88% <72.88%> (ø)
src/envs/go_to_target_undirected.jl 82.05% <82.05%> (ø)
src/rlbase.jl 84.52% <87.50%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2f104...609315e. Read the comment docs.

@Sid-Bhatia-0 Sid-Bhatia-0 merged commit 200279f into JuliaReinforcementLearning:master Jul 5, 2021
@Sid-Bhatia-0 Sid-Bhatia-0 deleted the revamp_go_to_target branch July 5, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants