When a pattern variable is defined on only one side of a disjunction, #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is now an error to use it again later in the pattern, or in a value expression. The reason is that the semantics are too confusing. If you get this error, just rename the pattern variable to avoid the conflict, or use a wildcard instead. This is technically a breaking change, but I'm guessing that it will occur only rarely in practice. Therefore I am only bumping the minor version number. Fixes #99
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 1036 1049 +13
=========================================
+ Hits 1036 1049 +13 ☔ View full report in Codecov by Sentry. |
|
@mcmcgrath13 @quinnj @NHDaly I would love to have an opinion (and review) from any of you about this PR. |
mcmcgrath13
approved these changes
Dec 19, 2023
|
Could this new release be, well, released? It fixes some test errors on 1.11. |
Yes, I'll work on that tomorrow. Thanks for reminding me. |
|
@mcmcgrath13 You created a branch that reverts this change. What do you plan to do with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pattern variable is defined on only one side of a disjunction,
it is now an error to use it again later in the pattern, or in a value expression. The reason is that the semantics are too confusing. If you get this error, just rename the pattern variable to avoid the conflict, or use a wildcard instead.
This is technically a breaking change, but I'm guessing that it will occur only rarely in practice. Therefore I am only bumping the minor version number.
Fixes #99