Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linear API #127

Open
tmigot opened this issue Aug 22, 2022 · 4 comments · May be fixed by #140
Open

Add linear API #127

tmigot opened this issue Aug 22, 2022 · 4 comments · May be fixed by #140

Comments

@tmigot
Copy link
Member

tmigot commented Aug 22, 2022 •
edited

See NLPModels.jl 0.18/0.19

I have a draft here https://github.com/JuliaSmoothOptimizers/AmplNLReader.jl/tree/add-linear-API but we probably should add functions to the C interface.

There might be an issue to fix with NLPModelsTest as well: JuliaSmoothOptimizers/NLPModelsTest.jl#54
@amontoison
Copy link
Member

@tmigot Do you think that we can use your branch add-linear-API to fix the CI tests?

@tmigot
Copy link
Member Author

tmigot commented Apr 25, 2024

Yes that's a good idea. I think we were waiting for somebody to grab this.

Do you need me to open the PR?

@amontoison
Copy link
Member

Yes, I can continue it if you explain me what is missing.
Because the PR is quite old, I'm a little bit lost.

@tmigot tmigot linked a pull request Apr 26, 2024 that will close this issue
Open
@tmigot
Copy link
Member Author

tmigot commented Apr 26, 2024

No problem, I opened the PR and tried to add some comments. My PR was not ideal as it was only using the functions from Ampl API that were already exported. It might be that they have some tailored functions that we didn't have.

@tmigot tmigot mentioned this issue May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add linear API JuliaSmoothOptimizers/AmplNLReader.jl
2 participants
@tmigot @amontoison