Diagonal quasi-Newton operators #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpo
requested changes
Jul 27, 2022
Codecov ReportBase: 97.61% // Head: 97.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
- Coverage 97.61% 97.38% -0.24%
==========================================
Files 13 14 +1
Lines 965 994 +29
==========================================
+ Hits 942 968 +26
- Misses 23 26 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
dpo
requested changes
Jul 28, 2022
dpo
requested changes
Jul 30, 2022
dpo
reviewed
Aug 3, 2022
dpo
reviewed
Aug 6, 2022
|
dpo
reviewed
Sep 4, 2022
|
dpo
force-pushed
the
joshua
branch
2 times, most recently
from
a5530b1
to
a1fabed
Compare
|
|
|
geoffroyleconte
requested changes
Sep 5, 2022
dpo
requested changes
Sep 9, 2022
|
@geoffroyleconte Should be all fixed. Do you mind taking another quick look? |
|
It's expected that FreeBSD/nightly fail at the moment. |
geoffroyleconte
approved these changes
Sep 12, 2022
|
Thank you @Joshua-Wolff and @geoffroyleconte ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new Abstract type in lbfgs.jl