Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for Kronecker product scaling #254

Merged
merged 1 commit into from
Nov 12, 2022
Merged

fix for Kronecker product scaling #254

merged 1 commit into from
Nov 12, 2022

Conversation

fguevaravas
Copy link

The Kronecker product code currently does not deal with multiplication by scalars correctly. This is illustrated below:

using LinearOperators, LinearAlgebra
A = kron(opEye(2),I(1))
Matrix(2A)

This results in:

2×2 Matrix{Float64}:
 1.0  0.0
 0.0  1.0

when it should be 2 times identity.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
PROPACK.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

dpo
dpo approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fguevaravas !

@dpo dpo merged commit 9326bdc into JuliaSmoothOptimizers:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffroyleconte geoffroyleconte geoffroyleconte approved these changes

@dpo dpo dpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fguevaravas @dpo @geoffroyleconte