Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce compat bounds for SuiteSparse #408

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Introduce compat bounds for SuiteSparse #408

merged 2 commits into from
Jul 11, 2023

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Jul 11, 2023

Remove remnants from SuiteSparse 5 such as SuiteSparse_long

Fix #349

Remove remnants from SuiteSparse 5 such as SuiteSparse_long
@ViralBShah ViralBShah requested a review from rayegun July 11, 2023 02:00
@ViralBShah ViralBShah closed this Jul 11, 2023
@ViralBShah ViralBShah reopened this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #408 (c596887) into main (6ccc974) will decrease coverage by 0.41%.
The diff coverage is 81.27%.

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   93.97%   93.56%   -0.41%     
==========================================
  Files          12       12              
  Lines        7480     7506      +26     
==========================================
- Hits         7029     7023       -6     
- Misses        451      483      +32     
Impacted Files Coverage Δ
src/linalg.jl 96.09% <ø> (ø)
src/solvers/LibSuiteSparse.jl 100.00% <ø> (ø)
src/solvers/umfpack.jl 88.58% <ø> (ø)
src/solvers/cholmod.jl 87.26% <80.14%> (-3.39%) ⬇️
src/solvers/spqr.jl 86.48% <90.90%> (+0.07%) ⬆️
src/sparsevector.jl 95.60% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ViralBShah ViralBShah merged commit a9637dd into main Jul 11, 2023
9 of 15 checks passed
@ViralBShah ViralBShah deleted the vs/cleanups branch July 11, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to actually using JLLs
2 participants