Hook into new factorization dispatch mechanisms #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested locally, and the speed-up for larger wrapped sparse matrices is, not surprisingly, gigantic. |
Codecov Report
@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 85.43% 85.40% -0.04%
==========================================
Files 13 13
Lines 8728 8734 +6
==========================================
+ Hits 7457 7459 +2
- Misses 1271 1275 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dkarrasch
force-pushed
the
dk/lusparse
branch
from
33e8b6f
to
254b378
Compare
dkarrasch
changed the title
lu dispatch mechanism
dkarrasch
changed the title
|
Are we ready to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to JuliaLang/julia#51161 and JuliaLang/julia#51220. It should catch
lu,qrandcholeskycalls for wrapped sparse matrices (or, more generally, anything whoselucopyis anAbstractSparseMatrixCSC).Now also depends on JuliaLang/julia#51245.