Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode doc edit backlink #442

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Hardcode doc edit backlink #442

merged 2 commits into from
Jan 22, 2024

Conversation

LilithHafner
Copy link
Member

Currently, the "edit on github" link at https://docs.julialang.org/en/v1/stdlib/SparseArrays/ is broken (JuliaLang/julia#50035). This PR fixes that link. See also: JuliaLang/julia#51375

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (240ef90) 85.00% compared to head (b18744f) 84.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   85.00%   84.42%   -0.59%     
==========================================
  Files          12       12              
  Lines        8959     8959              
==========================================
- Hits         7616     7564      -52     
- Misses       1343     1395      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LilithHafner
Copy link
Member Author

Closing because @mortenpi is in the process of fixing this upstream. Sorry for the noise.

@rayegun
Copy link
Member

rayegun commented Jan 22, 2024

Hey @LilithHafner what's the status on upstream? Do we want to merge this for now?

@LilithHafner
Copy link
Member Author

The upstream PR merged, but unexpectedly did not fix the issue. It will eventually be fixed upstream, but I don't have a timeline for when. I think it is appropriate to merge this now and revert it once the upstream fix is confirmed.

@rayegun rayegun merged commit c8d4f49 into main Jan 22, 2024
6 of 9 checks passed
@rayegun rayegun deleted the lh/hardcode-backlinks branch January 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants