Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in getcommon() in cholmod #509

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

ViralBShah
Copy link
Member

@rayegun I am not sure if this is right. I couldn't find cholmod_common_l anywhere.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1aa6431) 85.00% compared to head (8cff691) 85.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   85.00%   85.00%           
=======================================
  Files          12       12           
  Lines        8967     8967           
=======================================
  Hits         7622     7622           
  Misses       1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah changed the title Fix getcommon() in cholmod Fix error message in getcommon() in cholmod Feb 7, 2024
@rayegun
Copy link
Member

rayegun commented Feb 7, 2024

Yeah that's just to ensure they stay separated.

What was this PR for? Oh error message nevermind.

Finished a paper deadline so I'll go through and try to clean things up

@ViralBShah
Copy link
Member Author

I was looking for anything that might help resolve the threaded tests that fail in github actions. They don't fail on the julia buildbots but they always fail in github actions - and I was wondering if that was a real bug on our side. Specifically making sure that structs are correctly created and mirror what CHOLMOD expects (no overflows, etc.).

@rayegun
Copy link
Member

rayegun commented Feb 7, 2024

Can you point me to the logs that fail? Is it just the GAs in this repo?

@ViralBShah
Copy link
Member Author

Yeah, see the failing windows tests in the CI right here in this PR. It times out in the threading tests.

@ViralBShah ViralBShah merged commit 4cc31f2 into main Feb 8, 2024
6 of 8 checks passed
@ViralBShah ViralBShah deleted the vs/cholmod_getcommon branch February 8, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants