Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust matvec and matmatmul! to new internal LinAlg interface #519

Merged
merged 5 commits into from
May 8, 2024

Conversation

dkarrasch
Copy link
Member

This is a companion PR to JuliaLang/julia#52439. It pushes creation of MulAddMul objects down the call path, so avoids it in all cases except for in-place sparse multiplication.

@dkarrasch dkarrasch closed this May 8, 2024
@dkarrasch dkarrasch reopened this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.00%. Comparing base (3b30333) to head (48f3784).

Files Patch % Lines
src/linalg.jl 91.30% 2 Missing ⚠️
src/sparsevector.jl 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   84.05%   84.00%   -0.06%     
==========================================
  Files          12       12              
  Lines        9020     9028       +8     
==========================================
+ Hits         7582     7584       +2     
- Misses       1438     1444       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkarrasch dkarrasch closed this May 8, 2024
@dkarrasch dkarrasch reopened this May 8, 2024
@dkarrasch dkarrasch merged commit a09f90b into main May 8, 2024
13 of 28 checks passed
@dkarrasch dkarrasch deleted the dk/matmul branch May 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants