Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparseMatrixCSC constructor with a Tuple of Integers #523

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Mar 29, 2024

With this, the following works:

julia> similar(SparseMatrixCSC{Float64,Int}, 2,2)
2×2 SparseMatrixCSC{Float64, Int64} with 0 stored entries:
       
       

Previously, this used to call the SparseMatrixCSC constructor with a Tuple of Ints, which was not defined. Similar constructors are added for SparseVector.

This should probably be backported to v1.11 as well as v1.10. I added the backport 1.10 label, but there doesn't seem to be one for v1.11.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (08d6ae1) to head (245ec1f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files          12       12           
  Lines        8967     8969    +2     
=======================================
+ Hits         6853     6855    +2     
  Misses       2114     2114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member

Merge?

@jishnub jishnub merged commit 33fbc75 into main Apr 4, 2024
9 checks passed
@jishnub jishnub deleted the jishnub/SparseMatrixCSCconsttuples branch April 4, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants