CI: don't run threads tests in Windows GHA CI
#529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 76.42% 76.04% -0.39%
==========================================
Files 12 12
Lines 8967 8945 -22
==========================================
- Hits 6853 6802 -51
- Misses 2114 2143 +29 ☔ View full report in Codecov by Sentry. |
ViralBShah
previously approved these changes
Apr 2, 2024
|
Hmm, still crashing with something threading related! |
|
Yeah looks like I need to try skipping some more of the threads tests. |
|
Actually, pretty sure it is something related to that pipe that is failing - and not the thing that is currently encapsulated. I believe @vtjnash said something about the pipe issue somewhere at one point. Also the multithreaded version runs in the later testset. |
|
Closing in favor of #530 (which is just a small modification of this PR, and some changes to the comments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #531
threadstests on non-Windowsthreadstests on Windows on Buildkite CIthreadstests on Windows on GitHub Actions CI