Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean for extrema #74

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Code clean for extrema #74

merged 1 commit into from
Jan 29, 2022

Conversation

N5N3
Copy link
Contributor

@N5N3 N5N3 commented Jan 19, 2022

JuliaLang/julia#43604 has been merged.
Thus we don't need these code.

@N5N3 N5N3 closed this Jan 19, 2022
@N5N3 N5N3 reopened this Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #74 (3c9245d) into main (16dd9bd) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   88.95%   89.16%   +0.21%     
==========================================
  Files           7        7              
  Lines        5667     5667              
==========================================
+ Hits         5041     5053      +12     
+ Misses        626      614      -12     
Impacted Files Coverage Δ
src/sparsematrix.jl 95.04% <100.00%> (+0.17%) ⬆️
src/sparsevector.jl 94.16% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dd9bd...3c9245d. Read the comment docs.

@N5N3 N5N3 closed this Jan 20, 2022
@N5N3 N5N3 reopened this Jan 20, 2022
@N5N3 N5N3 closed this Jan 21, 2022
@N5N3 N5N3 reopened this Jan 21, 2022
@N5N3 N5N3 closed this Jan 23, 2022
@N5N3 N5N3 reopened this Jan 23, 2022
@ViralBShah ViralBShah merged commit 8cf1c26 into JuliaSparse:main Jan 29, 2022
@N5N3 N5N3 deleted the extrema2 branch January 29, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants