Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

RFC: work around MethodErrors with Base.OneTo #205

Merged
merged 7 commits into from
Jul 11, 2016
Merged

RFC: work around MethodErrors with Base.OneTo #205

merged 7 commits into from
Jul 11, 2016

Commits on Jul 10, 2016

  1. Call map(last, ...) on broadcast_shape 

    to work around OneTo issue
    @tkelman
    tkelman committed Jul 10, 2016
    Configuration menu
    Copy the full SHA
    c51d3cf View commit details
    Browse the repository at this point in the history

  2. Alternate workaround by calling to_shape 

    on output of broadcast_shape and index_shape

still need to work out a checkbounds test
    @tkelman
    tkelman committed Jul 10, 2016
    Configuration menu
    Copy the full SHA
    34f613c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2016

  1. Generalize checkindex to AbstractUnitRange

    @timholy
    timholy committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    18fa47b View commit details
    Browse the repository at this point in the history

  2. Make broadcastshape const

    @timholy
    timholy committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    c33655b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from timholy/teh/checkindex 

    Teh/checkindex
    @tkelman
    tkelman authored Jul 11, 2016
    Configuration menu
    Copy the full SHA
    6d37063 View commit details
    Browse the repository at this point in the history

  4. Rename broadcastshape to _broadcast_shape 

    and indexshape to _index_shape
    @tkelman
    tkelman committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    819bdd3 View commit details
    Browse the repository at this point in the history

  5. Only use AbstractUnitRange if defined

    @tkelman
    tkelman committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    0e6b88e View commit details
    Browse the repository at this point in the history