Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result_type issues #211

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Fix result_type issues #211

merged 4 commits into from
Jan 29, 2021

Conversation

dkarrasch
Copy link
Member

Fixes #210, fixes #209.

It seems very hard to include a generic fallback à la result_type(...) = Float64 again. So, the fix to #209 is to handle the Missing case explicitly, and the fix to #210 is to insist that a result_type method be given for "exotic" metrics that cannot handle Number arguments, and so we do it for Haversine and Spherical_Angle.

@dkarrasch dkarrasch merged commit fa867d5 into JuliaStats:master Jan 29, 2021
@dkarrasch dkarrasch deleted the dk/fixes branch January 29, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.10.1 broke pairwise haversine Release 0.10.1 breaking for allowmissing arrays
1 participant