Merge pull request #1153 from mileslucas/patch-1

Micro improvements on MatrixNormal
JuliaStats · Oct 23, 2020 · 6ccae41 · 6ccae41
2 parents 6a22a99 + d1253e0
commit 6ccae41
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/matrix/matrixnormal.jl b/src/matrix/matrixnormal.jl
@@ -125,7 +125,7 @@ function _rand!(rng::AbstractRNG, d::MatrixNormal, Y::AbstractMatrix)
     X = randn(rng, n, p)
     A = cholesky(d.U).L
     B = cholesky(d.V).U
-    Y .= d.M + A * X * B
+    Y .= d.M .+ A * X * B
 end
 
 #  -----------------------------------------------------------------------------
@@ -154,7 +154,7 @@ end
 
 function _rand_params(::Type{MatrixNormal}, elty, n::Int, p::Int)
     M = randn(elty, n, p)
-    U = (X = 2rand(elty, n, n) .- 1; X * X')
-    V = (Y = 2rand(elty, p, p) .- 1; Y * Y')
+    U = (X = 2 .* rand(elty, n, n) .- 1; X * X')
+    V = (Y = 2 .* rand(elty, p, p) .- 1; Y * Y')
     return M, U, V
 end