Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ZeroVector with Zeros from FillArrays #1020

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

devmotion
Copy link
Member

Fixes #833.

@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #1020 into master will increase coverage by 0.02%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
+ Coverage   77.92%   77.95%   +0.02%     
==========================================
  Files         112      112              
  Lines        5391     5362      -29     
==========================================
- Hits         4201     4180      -21     
+ Misses       1190     1182       -8
Impacted Files Coverage Δ
src/Distributions.jl 100% <ø> (ø) ⬆️
src/multivariate/mvnormal.jl 71.59% <100%> (ø) ⬆️
src/multivariate/mvtdist.jl 59.78% <100%> (ø) ⬆️
src/multivariate/mvlognormal.jl 96.82% <100%> (ø) ⬆️
src/multivariate/mvnormalcanon.jl 78.72% <66.66%> (-2.13%) ⬇️
src/utils.jl 80% <83.33%> (+6.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802a65b...899c1c2. Read the comment docs.

@matbesancon
Copy link
Member

Could you add a compat entry for FillArrays at 0.8 in the Project.toml?

@matbesancon
Copy link
Member

Cool, merging as soon as this shows green, thank you for this

@matbesancon matbesancon merged commit 345d1e0 into JuliaStats:master Dec 2, 2019
@devmotion devmotion deleted the fillarrays branch December 2, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ZeroVector with FillArrays
3 participants