Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump patch number #1215

Merged
merged 1 commit into from
Nov 8, 2020
Merged

bump patch number #1215

merged 1 commit into from
Nov 8, 2020

Conversation

piever
Copy link
Contributor

@piever piever commented Nov 8, 2020

Would it be possible to merge this and tag a new patch release? I would like to use the fix from #1206 in another package.

@andreasnoack
Copy link
Member

Do you know if the struct is used downstream? There is a small risk that the change could be breaking but I'd prefer not to make this a minor release.

@piever
Copy link
Contributor Author

piever commented Nov 8, 2020

The only uses I know are in StatsPlots / AbstractPlotting, but they are unaffected by this. The only thing that would break is code that relies on the fact that QQPair is concretely typed, but I'm not aware of any example of that in practice. I'd also say it's OK to make this a patch release.

@codecov-io
Copy link

Codecov Report

Merging #1215 (15b9983) into master (50ce715) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   81.79%   81.79%           
=======================================
  Files         116      116           
  Lines        6558     6558           
=======================================
  Hits         5364     5364           
  Misses       1194     1194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ce715...15b9983. Read the comment docs.

@andreasnoack andreasnoack merged commit ae2d6c5 into JuliaStats:master Nov 8, 2020
@piever piever deleted the pv/release branch November 8, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants