Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow general vectors in Dirichlet [BREAKING] #1243

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Allow general vectors in Dirichlet [BREAKING] #1243

merged 1 commit into from
Jan 12, 2021

Conversation

devmotion
Copy link
Member

This PR generalizes Dirichlet to general AbstractVectors of parameters.

This change allows to use Fill instead of fill for the special case of equal alpha parameter in every dimension, which also simplifies and improves efficiency of computations of var and entropy as well as sampling. In some places hardcoded Float64 had to be removed.

@devmotion
Copy link
Member Author

I also added a missing check_args keyword argument.

@devmotion devmotion mentioned this pull request Dec 22, 2020
Merged
@devmotion
Copy link
Member Author

Bump 🙂

1 similar comment
@devmotion
Copy link
Member Author

Bump 🙂

@andreasnoack andreasnoack changed the title Allow general vectors in Dirichlet Allow general vectors in Dirichlet [BREAKING] Jan 12, 2021
@andreasnoack andreasnoack merged commit ccebbd7 into JuliaStats:master Jan 12, 2021
@devmotion devmotion deleted the dirichlet branch January 12, 2021 14:07
This was referenced Jan 28, 2021
Merged
Closed
@ztangent ztangent mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmotion @andreasnoack