MvNormal and MvTDist 32-bit logpdf fixes #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logpdf should probably return 32-bit results if only 32-bit inputs are provided. This only fixes it for MvNormal and MvTDist since that's what I'm working with. Not sure if my tests fit with the current organizational system.
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 81.81% 81.82%
=======================================
Files 117 117
Lines 6589 6591 +2
=======================================
+ Hits 5391 5393 +2
Misses 1198 1198
Continue to review full report at Codecov.
|
|
It would be great to also have the other methods for |
|
My plan was to address these as they come up to avoid an overly large PR. If you'd prefer I can probably make some time to do a full scan over those Distributions types? Also, should I make a PR to tag a patch release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logpdf should probably return 32-bit results if only 32-bit inputs are provided.
This only fixes it for MvNormal and MvTDist since that's what I'm working with.
Not sure if my tests fit with the current organizational system.