Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FillArrays dep #1259

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Bump FillArrays dep #1259

merged 2 commits into from
Jan 21, 2021

Conversation

willtebbutt
Copy link
Contributor

@willtebbutt willtebbutt commented Jan 16, 2021

Also bumps the patch version so we can tag a release.

@willtebbutt
Copy link
Contributor Author

@matbesancon hopefully this is trivial to review.

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #1259 (84677ad) into master (997f2bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1259   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files         117      117           
  Lines        6565     6565           
=======================================
  Hits         5369     5369           
  Misses       1196     1196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997f2bb...84677ad. Read the comment docs.

@matbesancon
Copy link
Member

sorry, crazy under water here and haven't looked at Distributions for a long time, we should make you a maintainer for this sort of things

@matbesancon matbesancon merged commit cff479e into JuliaStats:master Jan 21, 2021
@willtebbutt willtebbutt deleted the wct/fill-arrays-bump branch January 21, 2021 10:33
@willtebbutt
Copy link
Contributor Author

Thanks for sorting this out!

@matbesancon
Copy link
Member

No problem, if you want to go through other PRs and review, if some are ready to merge feel free to ping me

@willtebbutt
Copy link
Contributor Author

As much as I would love to, I'm also somewhat swamped -- just trying to propagate updates through the ecosystem so that I can upgrade the GP ecosystem 😂

@devmotion
Copy link
Member

Just as a note: another unreleased commit on master that ended up in this release was marked as "BREAKING".

@willtebbutt
Copy link
Contributor Author

😬

@andreasnoack
Copy link
Member

andreasnoack commented Jan 21, 2021

I just checked the compare view and it's not easy to see neither the "breaking" label nor the [BREAKING] part I added to the title. I'm not sure how to make it more visible. Any ideas/

@devmotion
Copy link
Member

Maybe try to enforce that the version number is updated in PRs? This might not only make it less likely that it is updated incorrectly later on (in particular, if a different maintainer makes the release) but would also allow to make a release directly after the PR is merged.

@willtebbutt
Copy link
Contributor Author

willtebbutt commented Jan 21, 2021

Possibly Distributions should consider separating out master from DEV-new-minor-version -- it would be a shame if breaking changes held up non-breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants