-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump FillArrays dep #1259
Bump FillArrays dep #1259
Conversation
@matbesancon hopefully this is trivial to review. |
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 117 117
Lines 6565 6565
=======================================
Hits 5369 5369
Misses 1196 1196 Continue to review full report at Codecov.
|
sorry, crazy under water here and haven't looked at Distributions for a long time, we should make you a maintainer for this sort of things |
Thanks for sorting this out! |
No problem, if you want to go through other PRs and review, if some are ready to merge feel free to ping me |
As much as I would love to, I'm also somewhat swamped -- just trying to propagate updates through the ecosystem so that I can upgrade the GP ecosystem 😂 |
Just as a note: another unreleased commit on master that ended up in this release was marked as "BREAKING". |
😬 |
I just checked the |
Maybe try to enforce that the version number is updated in PRs? This might not only make it less likely that it is updated incorrectly later on (in particular, if a different maintainer makes the release) but would also allow to make a release directly after the PR is merged. |
Possibly |
Also bumps the patch version so we can tag a release.